Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Sep 8, 2023

This follows up on several old PR to clean a bit this part of knitr code and makes it clearer

Opening this PR to run our test suite

Copy link
Collaborator

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know about that removed is_html check, but other than that, LGTM

@cscheid cscheid self-requested a review September 9, 2023 16:16
@cderv cderv merged commit c738937 into main Sep 11, 2023
@cderv cderv deleted the fix/knitr/ojs-define-env branch September 11, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants