Skip to content

Comments

Fix index off by one error for flux percential ratio#11

Open
stevenstetzler wants to merge 19 commits intoquatrope:masterfrom
stevenstetzler:master
Open

Fix index off by one error for flux percential ratio#11
stevenstetzler wants to merge 19 commits intoquatrope:masterfrom
stevenstetzler:master

Conversation

@stevenstetzler
Copy link

Here's the PR. Perhaps it would be good to rename

lc_length = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_length))
...

to

lc_length = len(sorted_data)
lc_index = lc_length - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

or to

lc_index = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

to keep the semantics of the variable lc_length consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants