Skip to content

Comments

[Proposal] Add retry limit global configuration#145

Closed
tpitale wants to merge 1 commit intoque-rb:masterfrom
tpitale:retry-limit
Closed

[Proposal] Add retry limit global configuration#145
tpitale wants to merge 1 commit intoque-rb:masterfrom
tpitale:retry-limit

Conversation

@tpitale
Copy link

@tpitale tpitale commented Mar 23, 2016

  • Que.retry_limit, with default to 100
  • Lock job query uses retry_limit against error_count
  • Update docs

* Que.retry_limit, with default to 100
* Lock job query uses retry_limit against error_count
* Update docs
@tpitale
Copy link
Author

tpitale commented Mar 23, 2016

Looks like the build is failing on master already: https://travis-ci.org/chanks/que/jobs/113501122.

@joevandyk
Copy link
Contributor

rubygems/bundler#3558 looks related

On Wed, Mar 23, 2016 at 9:51 AM, Tony Pitale notifications@github.com
wrote:

Looks like the build is failing on master already:
https://travis-ci.org/chanks/que/jobs/113501122.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#145 (comment)

@tpitale
Copy link
Author

tpitale commented Mar 23, 2016

Based on comment on #106 it appears that the suggested method for this case may simply be to add a custom handle_error which moves or destroys the job when it should no longer be retried.

I may open another PR with more docs added to this area:

https://github.com/chanks/que/blob/master/docs/customizing_que.md#not-retrying-certain-failed-jobs

@tpitale tpitale closed this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants