Fix lock leak on PostgreSQL 12 and later#298
Merged
siegy22 merged 4 commits intoque-rb:masterfrom Jan 26, 2021
Merged
Conversation
PostgreSQL 12 drops this obsolete column. https://www.postgresql.org/docs/12/release-12.html: > Remove obsolete pg_attrdef.adsrc column (Peter Eisentraut) > > This column has been deprecated for a long time, because it > did not update in response to other catalog changes (such as > column renamings). The recommended way to get a text version > of a default-value expression from `pg_attrdef` is > `pg_get_expr(adbin, adrelid)`.
PostgreSQL 12 and later do not materialise all CTEs automatically. This can result in multiple scans occurring which in turn can result in `pg_try_advisory_lock` being invoked multiple times on the same job. This results in a leak as we only call unlock once.
Member
|
Thank you very much! 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290.
PostgreSQL 12 and later do not materialise all CTEs automatically. This can result in multiple scans occurring which in turn can result in
pg_try_advisory_lockbeing invoked multiple times on the same job. This results in a leak as we only call unlock once. This PR forces the CTE in the locker to be materialised which matches pre-PostgreSQL 12 behaviour.I wasn’t able to reproduce any similar issues with the polling code but it’s possible the same issue exists there. I suspect the
lock_takenCTE being used twice inlock_and_update_prioritiesis enough to trigger the materialisation path there.This PR also fixes the use of an obsolete column in
pg_attrdefwhich was preventing a green build on PostgreSQL 12.