Skip to content

Comments

Fixes for Ruby v3.#302

Closed
stas wants to merge 2 commits intoque-rb:masterfrom
stas:master
Closed

Fixes for Ruby v3.#302
stas wants to merge 2 commits intoque-rb:masterfrom
stas:master

Conversation

@stas
Copy link

@stas stas commented Jan 10, 2021

Minor fixes for Ruby v3.

stas added 2 commits January 10, 2021 18:14
Remove the rescue block.
It's not needed and makes it really hard to trace the issues.
@ZimbiX
Copy link
Member

ZimbiX commented Sep 2, 2021

I think I agree with the removal of the rescue. But I also think this PR should be closed in favour of the more progressed #303 (though it sounds like there are more significant changes required than that). Maybe propose the rescue change separately =)

@stas
Copy link
Author

stas commented Sep 2, 2021

Happy to update the PR if we want it merged 🙃

@ZimbiX
Copy link
Member

ZimbiX commented Dec 16, 2021

I reckon this can be closed as superseded by #319. Let's open a new PR once that goes though to remove the rescue =)

@ZimbiX ZimbiX closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants