Add Docker for easier setup of Que development environment#324
Merged
Add Docker for easier setup of Que development environment#324
Conversation
Providing a Docker Compose service for running PostgreSQL, with a script for running the tests, makes it a lot easier to get started for developing Que. You no longer need to have installed & started PostgreSQL, set `DATABASE_URL` appropriately, or created a database for Que. Different versions of PostgreSQL can also be tested easily, by setting `POSTGRES_VERSION` - e.g. `auto/test-postgres-14`. This setup follows GreenSync conventions, although `auto/test` is not used on GitHub Actions. I've used the latest Ruby Docker image for Ruby 2.7. We can update this to Ruby 3 in #319.
Docker Compose is now included in Docker as a subcommand; so `docker compose` is already available once Docker is installed, whereas using `docker-compose` requires the separate installation of the `docker-compose` package, which is now just a wrapper program.
Using just Docker Compose keeps the documentation simpler, and it's included with Docker now
We've had trouble in the past with this preventing certian Bundler commands from working properly
For consistency with other GreenSync repos, which need to avoid ruby/rubygems#5339
maddymarkovitz
approved these changes
Feb 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing a Docker Compose service for running PostgreSQL, with a script for running the tests, makes it a lot easier to get started for developing Que. You no longer need to have installed & started PostgreSQL, set
DATABASE_URLappropriately, or created a database for Que. Different versions of PostgreSQL can also be tested easily, by settingPOSTGRES_VERSION- e.g.auto/test-postgres-14.This setup follows GreenSync conventions, although
auto/testis not used on GitHub Actions.I've used the latest Ruby Docker image for Ruby 2.7. We can update this to Ruby 3 in #319.