Move CommandLineInterface from bin to lib#378
Merged
ZimbiX merged 1 commit intoque-rb:masterfrom Aug 26, 2022
Merged
Conversation
ZimbiX
approved these changes
Aug 26, 2022
ZimbiX
requested changes
Aug 26, 2022
Member
There was a problem hiding this comment.
Thanks for this =)
The tests are failing though =\
/work/spec/que/command_line_interface_spec.rb:7:in `<top (required)>': uninitialized constant Que::CommandLineInterface (NameError)
It passes with:
diff --git a/lib/que.rb b/lib/que.rb
index f54832c..d01866e 100644
--- a/lib/que.rb
+++ b/lib/que.rb
@@ -36,6 +36,7 @@ module Que
require_relative 'que/connection'
require_relative 'que/connection_pool'
+ require_relative 'que/command_line_interface'
require_relative 'que/job_methods'
require_relative 'que/job'
require_relative 'que/job_buffer'This will support other programs running other business logic before
starting the que locker and workers.
```
exit_code =
Que::CommandLineInterface.parse(
args: ARGV.dup,
output: $stdout,
)
exit(exit_code)
```
5103bc5 to
8dfbee4
Compare
Contributor
Author
I tried to avoid requiring |
Member
Fair enough =) |
ZimbiX
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will support other programs running business logic/setup before
starting the que locker and workers like so: