Skip to content

[QEff Finetune]: Added support for gradient checkpointing in the finetuning script.#338

Merged
quic-swatia merged 11 commits intoquic:mainfrom
quic-meetkuma:grad_checkpointing
Apr 11, 2025
Merged

[QEff Finetune]: Added support for gradient checkpointing in the finetuning script.#338
quic-swatia merged 11 commits intoquic:mainfrom
quic-meetkuma:grad_checkpointing

Conversation

@quic-meetkuma
Copy link
Copy Markdown
Contributor

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has "supports_gradient_checkpointing" attribute set to True.

@quic-meetkuma quic-meetkuma marked this pull request as draft April 2, 2025 12:33
@quic-meetkuma quic-meetkuma force-pushed the grad_checkpointing branch 4 times, most recently from 58c13e9 to 0b1c369 Compare April 7, 2025 10:50
@quic-meetkuma quic-meetkuma marked this pull request as ready for review April 7, 2025 11:04
Comment thread QEfficient/finetune/dataset/samsum_dataset.py
Comment thread QEfficient/finetune/utils/train_utils.py Outdated
@quic-mamta quic-mamta changed the title Added support for gradient checkpointing in the finetuning script. [QEff Finetune]: Added support for gradient checkpointing in the finetuning script. Apr 9, 2025
Copy link
Copy Markdown
Contributor Author

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add eager team's code reference for qaic_debug API changes.

Comment thread QEfficient/finetune/dataset/samsum_dataset.py
Comment thread QEfficient/finetune/utils/train_utils.py Outdated
Comment thread QEfficient/finetune/utils/train_utils.py Outdated
Comment thread QEfficient/finetune/utils/train_utils.py Outdated
Copy link
Copy Markdown
Contributor Author

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix couple of comments.

Comment thread QEfficient/cloud/finetune.py
Comment thread QEfficient/finetune/utils/train_utils.py
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
@quic-swatia quic-swatia merged commit b88b758 into quic:main Apr 11, 2025
1 check passed
quic-dhirajku pushed a commit that referenced this pull request Apr 16, 2025
…tuning script. (#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
shubhagr-qc pushed a commit to shubhagr-qc/efficient-transformers that referenced this pull request Apr 21, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
quic-meetkuma added a commit to vbaddi/efficient-transformers that referenced this pull request Apr 21, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>
Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>

Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
…tuning script. (quic#338)

Added --gradient_checkpointing new CLI flag to enable this feature.
Currently this is enabled for all the HF models which has
"supports_gradient_checkpointing" attribute set to True.

---------

Signed-off-by: Meet Patel <quic_meetkuma@quicinc.com>

Signed-off-by: eplatero <quic_eplatero@quicinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants