Skip to content

"[QEff.finetuning] Adding config_manager and its test cases."#656

Merged
quic-akuruvil merged 15 commits intoquic:ft_experimentalfrom
tchawada:hf_config_manager
Dec 15, 2025
Merged

"[QEff.finetuning] Adding config_manager and its test cases."#656
quic-akuruvil merged 15 commits intoquic:ft_experimentalfrom
tchawada:hf_config_manager

Conversation

@tchawada
Copy link
Copy Markdown
Contributor

@tchawada tchawada commented Dec 9, 2025

Added Config_manager to parse the training, model and dataset related arguments.

@tchawada
Adding optimizer registry and its test cases
c3d819c 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Adding optimizer registry and its test cases
9e402bc 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Adding optimizer registry and its test cases
34f15c4 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
[QEff. Finetuning]: Optimizer registry and test case inclusion
1d7d4c2 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
[QEff_Finetuning] Adding callback and its test cases.
926a49f 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
[QEff_Finetuning] Adding callback and its test cases.
000da81 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
[QEff.finetuning] Adding config_manager and its test cases.
94eab12 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
[QEff.finetuning] Adding config_manager and its test cases.
28ec40b 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-meetkuma
quic-meetkuma requested changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@quic-meetkuma quic-meetkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner implementation, please fix comments and we will merge it.

Comment thread QEfficient/finetune/experimental/core/config_manager.py
Comment thread QEfficient/finetune/experimental/core/config_manager.py
Comment thread QEfficient/finetune/experimental/core/config_manager.py Outdated
Comment thread QEfficient/finetune/experimental/core/config_manager.py
Comment thread QEfficient/finetune/experimental/core/config_manager.py Outdated
Comment thread QEfficient/finetune/experimental/tests/test_config.yaml Outdated
Comment thread QEfficient/finetune/experimental/tests/test_config_manager.py Outdated
Comment thread QEfficient/finetune/experimental/tests/test_config_manager.py
quic-akuruvil
quic-akuruvil reviewed Dec 9, 2025
View reviewed changes
Comment thread QEfficient/finetune/experimental/tests/test_config_manager.py
@tchawada
[QEff.finetuning] Adding config_manager and its test_cases.
1f0a4df 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Delete QEfficient/finetune/experimental/tests/test_optimizer.py
2cd53db 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Delete QEfficient/finetune/experimental/tests/test_callback.py
c53d7b3 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Update optimizer.py
b75e8b7 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Update callbacks.py
13e3274 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada tchawada requested a review from quic-swatia December 11, 2025 08:45
@tchawada
Update config_manager.py
54c3bba 
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-akuruvil
quic-akuruvil reviewed Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@quic-akuruvil quic-akuruvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-akuruvil quic-akuruvil merged commit 609771a into quic:ft_experimental Dec 15, 2025
3 of 4 checks passed
quic-akuruvil added a commit that referenced this pull request Dec 15, 2025
@quic-akuruvil
Revert " "[QEff.finetuning] Adding config_manager and its test cases." (
ec86192 
#656)"

This reverts commit 609771a.
@quic-akuruvil quic-akuruvil mentioned this pull request Dec 15, 2025
Merged
quic-akuruvil added a commit that referenced this pull request Dec 15, 2025
@quic-akuruvil
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
9666cfb 
…"" (#666)

Reverts #656
quic-dhirajku pushed a commit that referenced this pull request Jan 2, 2026
@tchawada @quic-dhirajku
"[QEff.finetuning] Adding config_manager and its test cases." (#656)
46fca42 
Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-dhirajku pushed a commit that referenced this pull request Jan 2, 2026
@quic-akuruvil @quic-dhirajku
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
c80d0a8 
…"" (#666)

Reverts #656
tchawada added a commit to tchawada/QEff_tanisha that referenced this pull request Feb 5, 2026
@tchawada
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
c07d8ea 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
tchawada pushed a commit to tchawada/QEff_tanisha that referenced this pull request Feb 5, 2026
@quic-akuruvil @tchawada
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
d4120a5 
…"" (quic#666)

Reverts quic#656
quic-swatia pushed a commit to quic-swatia/efficient-transformers that referenced this pull request Feb 9, 2026
@tchawada @quic-swatia
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
0867fae 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-swatia pushed a commit to quic-swatia/efficient-transformers that referenced this pull request Feb 9, 2026
@quic-akuruvil @quic-swatia
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
2a77f34 
…"" (quic#666)

Reverts quic#656
quic-akuruvil pushed a commit to quic-akuruvil/efficient_transformers that referenced this pull request Feb 9, 2026
@tchawada @quic-akuruvil
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
421eee4 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-akuruvil added a commit to quic-akuruvil/efficient_transformers that referenced this pull request Feb 9, 2026
@quic-akuruvil
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
f263496 
…"" (quic#666)

Reverts quic#656
quic-akuruvil pushed a commit to quic-akuruvil/efficient_transformers that referenced this pull request Feb 16, 2026
@tchawada @quic-akuruvil
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
271121f 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-akuruvil added a commit to quic-akuruvil/efficient_transformers that referenced this pull request Feb 16, 2026
@quic-akuruvil
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
70a9e11 
…"" (quic#666)

Reverts quic#656
quic-swatia pushed a commit to quic-swatia/efficient-transformers that referenced this pull request Feb 26, 2026
@tchawada @quic-swatia
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
11d810e 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-swatia pushed a commit to quic-swatia/efficient-transformers that referenced this pull request Feb 26, 2026
@quic-akuruvil @quic-swatia
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
9e44af9 
…"" (quic#666)

Reverts quic#656
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
9efce95 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
cba3161 
…"" (quic#666)

Reverts quic#656
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
a6e3b8c 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
22a9881 
…"" (quic#666)

Reverts quic#656

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
304516e 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
8d5283d 
…"" (quic#666)

Reverts quic#656

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
cc3d9f0 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
00c3eeb 
…"" (quic#666)

Reverts quic#656

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
66d1827 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
0cfd7ba 
…"" (quic#666)

Reverts quic#656

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@tchawada @quic-dhirajku
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
0c187aa 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-akuruvil @quic-dhirajku
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
0656fbf 
…"" (quic#666)

Reverts quic#656
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 9, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
0a5c49d 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 9, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
9482e3d 
…"" (quic#666)

Reverts quic#656
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 10, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
b150935 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 10, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
e4debe9 
…"" (quic#666)

Reverts quic#656
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 17, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
7dcb29b 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 17, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
86df5aa 
…"" (quic#666)

Reverts quic#656
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 18, 2026
@tchawada @smedhe
"[QEff.finetuning] Adding config_manager and its test cases." (quic#656
d0918e9 
)

Added Config_manager to parse the training, model and dataset related
arguments.

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 18, 2026
@quic-akuruvil @smedhe
Revert " "[QEff.finetuning] Adding config_manager and its test cases.…
cc9705d 
…"" (quic#666)

Reverts quic#656

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quic-akuruvil quic-akuruvil quic-akuruvil left review comments

@quic-meetkuma quic-meetkuma quic-meetkuma requested changes

@quic-rishinr quic-rishinr Awaiting requested review from quic-rishinr quic-rishinr is a code owner

@ochougul ochougul Awaiting requested review from ochougul ochougul is a code owner

@quic-hemagnih quic-hemagnih Awaiting requested review from quic-hemagnih quic-hemagnih is a code owner

@quic-amitraj quic-amitraj Awaiting requested review from quic-amitraj quic-amitraj is a code owner

@quic-swatia quic-swatia Awaiting requested review from quic-swatia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tchawada @quic-akuruvil @quic-meetkuma