Fixing SW issue in Gemma3#740
Merged
quic-hemagnih merged 13 commits intoquic:mainfrom Jan 28, 2026
Merged
Conversation
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
qcdipankar
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
quic-hemagnih
requested changes
Jan 21, 2026
| residual = hidden_states | ||
| hidden_states = self.input_layernorm(hidden_states) | ||
| past_seen_tokens = past_key_value.get_seq_length() if past_key_value is not None else 0 | ||
| # past_seen_tokens = past_key_value.get_seq_length() if past_key_value is not None else 0 |
Contributor
Author
There was a problem hiding this comment.
apologies need to remove the comments
ochougul
requested changes
Jan 22, 2026
Contributor
ochougul
left a comment
ochougul
left a comment
There was a problem hiding this comment.
Please rerun using update method instead of update_old method from PR https://github.com/quic/efficient-transformers/pull/719/changes
That is the code we would want, Let me know if that produces inaccurate results
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
ochougul
reviewed
Jan 23, 2026
ochougul
reviewed
Jan 23, 2026
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
quic-hemagnih
approved these changes
Jan 28, 2026
ochougul
reviewed
Jan 28, 2026
Comment on lines
+21
to
+23
| # For Testing Purpose Only atleast 6 layers are required | ||
| # config.text_config.num_hidden_layers = 6 | ||
| # config.vision_config.num_hidden_layers = 6 |
Contributor
There was a problem hiding this comment.
remove, we should run full model in example file
ochougul
approved these changes
Jan 28, 2026
qcdipankar
added a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Jan 30, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
quic-rishinr
pushed a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Feb 3, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
quic-hemagnih
added a commit
that referenced
this pull request
Feb 4, 2026
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 5, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
qcdipankar
added a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Feb 8, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 16, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 8, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 8, 2026
The SW issue came with prompt + generation length > SW. Fix 1. Cache updated with HybridSlidingWindowCache in cache utils --------- Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SW issue came with prompt + generation length > SW.
Fix