Fix for Diffusers subfunction#759
Merged
quic-rishinr merged 10 commits intoquic:mainfrom Feb 9, 2026
Merged
Conversation
Contributor
tv-karthikeya
commented
Jan 28, 2026
tv-karthikeya
commented
- skip subfn handling in export utils for diffusers, we handle this in export() of diffuser models
Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
tv-karthikeya
force-pushed
the
subfn_export
branch
from
13f4eff to
d4b2075
Compare
tv-karthikeya
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
vbaddi
reviewed
Jan 28, 2026
| # TODO: Handle this in the modelling class QEFFTransformersBase,remove from here. Refer diffusers implementation | ||
| submodule_classes = qeff_model.model.get_submodules_for_export() | ||
| if submodule_classes: | ||
| kwargs["export_modules_as_functions"] = submodule_classes |
Contributor
There was a problem hiding this comment.
nit: we will have to keep this consistent between Diffusers and transformers. @quic-rishinr Lets merge this change and @tv-karthikeya will add this change in next PR. (Note: This is only for mainline, release, we are good)
Contributor
There was a problem hiding this comment.
Agree, it should be uniform. there is no need of this param export_modules_as_function, We can remove this as we have done in the diffusers.
Contributor
There was a problem hiding this comment.
No, the idea was to handle all subfunction‑related logic inside export_utils rather than in the export itself. This keeps the design cleaner and more aligned so i would suggest changing diffusers code.
Contributor
There was a problem hiding this comment.
We don't need this for release, we will merge only to mainline.
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
| # Both high and low noise transformers share the same configuration | ||
| self.config = transformer_high.config | ||
|
|
||
| def get_submodules_for_export(self) -> Type[nn.Module]: |
Contributor
There was a problem hiding this comment.
@tv-karthikeya Technically this class should be in the transformer_wan.py. Could you please move this class there. Except that all seems good.
Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
tv-karthikeya
force-pushed
the
subfn_export
branch
from
7e2805e to
51a7d1a
Compare
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 16, 2026
- skip subfn handling in export utils for diffusers, we handle this in export() of diffuser models --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Co-authored-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 8, 2026
- skip subfn handling in export utils for diffusers, we handle this in export() of diffuser models --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Co-authored-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 8, 2026
- skip subfn handling in export utils for diffusers, we handle this in export() of diffuser models --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Co-authored-by: Abhishek Kumar Singh <sabhis@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com> Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.