Skip to content

[QEff. Finetuning]: Adding PP support in HF trainer stack#813

Merged
quic-swatia merged 3 commits intoquic:ft_experimentalfrom
quic-swatia:PP
Feb 27, 2026
Merged

[QEff. Finetuning]: Adding PP support in HF trainer stack#813
quic-swatia merged 3 commits intoquic:ft_experimentalfrom
quic-swatia:PP

Conversation

@quic-swatia
Copy link
Copy Markdown
Contributor

@quic-swatia quic-swatia commented Feb 26, 2026 •
edited
Loading

  • Added PP support in HF trainer stack.
  • Updated the documentation for the same.
  • Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m QEfficient.cloud.finetune_experimental QEfficient/finetune/experimental/configs/sample_pp_config.yaml

@quic-swatia
Adding PP support in HF trainer stack
c6ffc77 
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
@quic-swatia
Fix linting error
a4917a3 
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
quic-akuruvil
quic-akuruvil reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@quic-akuruvil quic-akuruvil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the sample command used to test only PP through CLI args.

quic-akuruvil
quic-akuruvil reviewed Feb 26, 2026
View reviewed changes
Comment thread QEfficient/finetune/experimental/core/utils/device_map_utils.py
@quic-swatia
Copy link
Copy Markdown
Contributor Author

quic-swatia commented Feb 26, 2026

Could you add the sample command used to test only PP through CLI args.

CLI in HF stack for any FT job will work properly after #795 fix. Meanwhile, PP can be tested through yaml file.

@quic-swatia
Copy link
Copy Markdown
Contributor Author

quic-swatia commented Feb 26, 2026

Could you add the sample command used to test only PP through CLI args.

CLI args option in HF stack for any FT job will be functional with the changes of #795. PP can be tested through yaml file, command is mentioned in desc.

quic-akuruvil
quic-akuruvil reviewed Feb 26, 2026
View reviewed changes
Comment thread QEfficient/finetune/experimental/core/utils/device_map_utils.py Outdated
quic-akuruvil
quic-akuruvil reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@quic-akuruvil quic-akuruvil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please reverify DDP with the new changes. Just to make sure this new PP changes doesn't affect it.

quic-meetkuma
quic-meetkuma requested changes Feb 26, 2026
View reviewed changes
Comment thread QEfficient/finetune/experimental/configs/sample_pp_config.yaml
Comment thread QEfficient/finetune/experimental/core/config_manager.py
Comment thread QEfficient/finetune/experimental/core/config_manager.py Outdated
Comment thread QEfficient/finetune/experimental/core/model.py Outdated
Comment thread QEfficient/cloud/finetune_experimental.py Outdated
Comment thread QEfficient/cloud/finetune_experimental.py Outdated
Comment thread QEfficient/cloud/finetune_experimental.py Outdated
@quic-swatia
Addressed review comments, added documentation for PP
e4b675a 
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
@quic-swatia quic-swatia self-assigned this Feb 26, 2026
@quic-swatia quic-swatia changed the title Adding PP support in HF trainer stack [QEff. Finetuning]: Adding PP support in HF trainer stack Feb 26, 2026
@quic-swatia
Copy link
Copy Markdown
Contributor Author

quic-swatia commented Feb 26, 2026

Also please reverify DDP with the new changes. Just to make sure this new PP changes doesn't affect it.

Yes, verified that it's working.

@quic-swatia quic-swatia merged commit c0ef8cc into quic:ft_experimental Feb 27, 2026
3 checks passed
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
6dd44b8 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
c4f47d5 
* Added PP support in HF trainer stack.
* Updated the documentation for the same.
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 6, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
0c602e6 
* Added PP support in HF trainer stack.
* Updated the documentation for the same.
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
e9d922b 
* Added PP support in HF trainer stack.
* Updated the documentation for the same.
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
396826e 
* Added PP support in HF trainer stack.
* Updated the documentation for the same.
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>

Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 8, 2026
@quic-swatia
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
1248fb0 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
Signed-off-by: Sharvari Medhe <smedhe@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 9, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
f8ff452 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 10, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
12f6f11 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 17, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
5b2db2c 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 23, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
d7aff24 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 23, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
1c4d4c0 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 23, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
d968122 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 24, 2026
@quic-swatia @smedhe
[QEff. Finetuning]: Adding PP support in HF trainer stack (quic#813)
b3dec98 
* Added PP support in HF trainer stack. 
* Updated the documentation for the same. 
* Sample command to test PP : QAIC_VISIBLE_DEVICES=0,1 python -m
QEfficient.cloud.finetune_experimental
QEfficient/finetune/experimental/configs/sample_pp_config.yaml

---------

Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm>
@quic-swatia quic-swatia mentioned this pull request Mar 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quic-akuruvil quic-akuruvil quic-akuruvil left review comments

@quic-meetkuma quic-meetkuma quic-meetkuma requested changes

@quic-rishinr quic-rishinr Awaiting requested review from quic-rishinr quic-rishinr is a code owner

@ochougul ochougul Awaiting requested review from ochougul ochougul is a code owner

@quic-hemagnih quic-hemagnih Awaiting requested review from quic-hemagnih quic-hemagnih is a code owner

@quic-amitraj quic-amitraj Awaiting requested review from quic-amitraj quic-amitraj is a code owner

Assignees

@quic-swatia quic-swatia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quic-swatia @quic-akuruvil @quic-meetkuma