[QEff. Finetuning]: Fixed Data Parallel issue#845
Merged
quic-swatia merged 3 commits intoquic:ft_experimentalfrom Mar 11, 2026
Merged
[QEff. Finetuning]: Fixed Data Parallel issue#845quic-swatia merged 3 commits intoquic:ft_experimentalfrom
quic-swatia merged 3 commits intoquic:ft_experimentalfrom
Conversation
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
quic-swatia
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
quic-swatia
changed the title
Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com>
| python -m QEfficient.cloud.finetune_experimental configs/sft_single_device_gsm8k_config.yaml | ||
| ``` | ||
| where `sample_pp_config.yaml` contains `pp_degree: 2` under `training:`. | ||
| where `sft_single_device_gsm8k_config.yaml` contains `pp_degree: 2` under `training:`. |
Contributor
There was a problem hiding this comment.
For pp_degree 2 , 2 devices are required right? But the config file name is ambiguous here. Can we not create a different file? And keep this file for single_device run?
Contributor
Author
There was a problem hiding this comment.
As discussed offline, since we only need one extra param ( i.e. pp_degree ) to be set >1, it will be better to reuse the existing config file.
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 17, 2026
1) Fixed Data Parallel issue. 2) Removed sample config for PP as the changes of config manager are now merged. 3) Updated the PP documentation accordingly. --------- Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com> Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 23, 2026
1) Fixed Data Parallel issue. 2) Removed sample config for PP as the changes of config manager are now merged. 3) Updated the PP documentation accordingly. --------- Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com> Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 23, 2026
1) Fixed Data Parallel issue. 2) Removed sample config for PP as the changes of config manager are now merged. 3) Updated the PP documentation accordingly. --------- Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com> Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
Mar 24, 2026
1) Fixed Data Parallel issue. 2) Removed sample config for PP as the changes of config manager are now merged. 3) Updated the PP documentation accordingly. --------- Signed-off-by: Swati Allabadi <sallabad@qti.qualcomm.com> Co-authored-by: Swati Allabadi <sallabad@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.