Skip to content

[QEff.finetune] FT logger#851

Merged
quic-akuruvil merged 4 commits intoquic:ft_experimentalfrom
tchawada:hf_logger
Mar 16, 2026
Merged

[QEff.finetune] FT logger#851
quic-akuruvil merged 4 commits intoquic:ft_experimentalfrom
tchawada:hf_logger

Conversation

@tchawada
Copy link
Copy Markdown
Contributor

Updated logger.py and test_logger

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Comment thread QEfficient/cloud/finetune_experimental.py Outdated
Comment thread QEfficient/finetune/experimental/tests/test_logger.py
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@@ -42,8 +42,6 @@ def is_nsp_free():
# Check if NSP free is eqaul to total nsp
if nsp_free != nsp_total:
raise RuntimeError(f"QAIC device {qid_idx} does not have {nsp_total} NSP free")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHy are we changing in the device_utils of AOT? Don't we have a separte device_utils for us, in finetune/experimental/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meet told to put it here, first I placed it in utils.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Copy link
Copy Markdown
Contributor

@quic-akuruvil quic-akuruvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@quic-akuruvil quic-akuruvil merged commit 2441f68 into quic:ft_experimental Mar 16, 2026
3 checks passed
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 17, 2026
Updated logger.py and test_logger

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 23, 2026
Updated logger.py and test_logger

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 23, 2026
Updated logger.py and test_logger

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
smedhe pushed a commit to smedhe/QEff_Sharvari that referenced this pull request Mar 24, 2026
Updated logger.py and test_logger

---------

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants