Skip to content

[QEff.finetune] Adding reference_data for comparing differences in loss values#892

Closed
tchawada wants to merge 3 commits intoquic:ft_experimentalfrom
tchawada:ft_ref_data
Closed

[QEff.finetune] Adding reference_data for comparing differences in loss values#892
tchawada wants to merge 3 commits intoquic:ft_experimentalfrom
tchawada:ft_ref_data

Conversation

@tchawada
Copy link
Copy Markdown
Contributor

Added testcase to test compare loss for different sdks to stable sdk

Comment thread QEfficient/finetune/experimental/tests/reference_data.py Outdated
run_training(trainer, config_name)
)
all_ref_metrices, all_config_spy = get_reference_metrics(scenario_key, config_manager)
verify_training_results(final_train_loss, final_eval_loss)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests we had added earlier right? Please make sure we run this test only once.

Comment thread QEfficient/finetune/experimental/tests/test_integrated.py
Copy link
Copy Markdown
Contributor

@quic-akuruvil quic-akuruvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quic-akuruvil
Copy link
Copy Markdown
Contributor

LGTM

LGTM

@rebase against ft/-experiemntal is pending

Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
@tchawada
Copy link
Copy Markdown
Contributor Author

Changes merged in PR #897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants