Skip to content

Merge event trigger case data on case create and update #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbenadikar merged 1 commit into from
Dec 8, 2021
Merged

Merge event trigger case data on case create and update #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/modules/case.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ const COLLECTION_ITEM_PATTERN = /^(?<name>[^\[\]]+)(?:\[(?:(?<colIndex>\d+)|id:(
* @return {Promise} Promise resolved with the created case
*/
export const createCase = (http) => (caseTypeId) => (eventId) => async (payload = {}) => {
const {data: {token}} = await http.get(`/case-types/${caseTypeId}/event-triggers/${eventId}`);
const {data: {token, case_details: {case_data: eventTriggerCaseData}}} = await http.get(`/case-types/${caseTypeId}/event-triggers/${eventId}`);
const createRes = await http.post(`/case-types/${caseTypeId}/cases`, {
data: payload.data,
data: {...eventTriggerCaseData, ...payload.data},
event: {
id: eventId,
summary: payload.summary,
Expand Down Expand Up @@ -200,9 +200,9 @@ export const isCaseIdentifier36 = (base36String) => isCaseIdentifier(idFrom36(ba
* @return {Promise} Promise resolved with the updated case
*/
export const updateCase = (http) => (caseId) => (eventId) => async (payload = {}) => {
const {data: {token}} = await http.get(`/cases/${caseId}/event-triggers/${eventId}`);
const {data: {token, case_details: {case_data: eventTriggerCaseData}}} = await http.get(`/cases/${caseId}/event-triggers/${eventId}`);
const updateRes = await http.post(`/cases/${caseId}/events`, {
data: payload.data,
data: {...eventTriggerCaseData, ...payload.data},
event: {
id: eventId,
summary: payload.summary,
Expand Down
32 changes: 22 additions & 10 deletions src/modules/case.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,12 +374,15 @@ describe('createCase', () => {
const httpStub = {
get: (url) => {
expect(url).toEqual(`/case-types/${caseTypeId}/event-triggers/${eventId}`);
return Promise.resolve({data: {token}});
return Promise.resolve({data: {token, case_details: {case_data: {field1: 'value0', field2: 'value2'}}}});
},
post: (url, body) => {
expect(url).toEqual(`/case-types/${caseTypeId}/cases`);
expect(body).toEqual({
data: payload.data,
data: {
field1: 'value1',
field2: 'value2',
},
event: {
id: eventId,
summary: payload.summary,
Expand All @@ -397,7 +400,10 @@ describe('createCase', () => {
const createdCase = await createCase(httpStub)(caseTypeId)(eventId)(payload);
expect(createdCase).toEqual({
id: caseId,
data: payload.data,
data: {
field1: 'value1',
field2: 'value2',
},
});
});

Expand All @@ -409,12 +415,12 @@ describe('createCase', () => {
const httpStub = {
get: (url) => {
expect(url).toEqual(`/case-types/${caseTypeId}/event-triggers/${eventId}`);
return Promise.resolve({data: {token}});
return Promise.resolve({data: {token, case_details: {case_data: {}}}});
},
post: (url, body) => {
expect(url).toEqual(`/case-types/${caseTypeId}/cases`);
expect(body).toEqual({
data: undefined,
data: {},
event: {
id: eventId,
summary: undefined,
Expand Down Expand Up @@ -450,12 +456,15 @@ describe('updateCase', () => {
const httpStub = {
get: (url) => {
expect(url).toEqual(`/cases/${caseId}/event-triggers/${eventId}`);
return Promise.resolve({data: {token}});
return Promise.resolve({data: {token, case_details: {case_data: {field1: 'value0', field2: 'value2'}}}});
},
post: (url, body) => {
expect(url).toEqual(`/cases/${caseId}/events`);
expect(body).toEqual({
data: payload.data,
data: {
field1: 'value1',
field2: 'value2',
},
event: {
id: eventId,
summary: payload.summary,
Expand All @@ -473,7 +482,10 @@ describe('updateCase', () => {
const updatedCase = await updateCase(httpStub)(caseId)(eventId)(payload);
expect(updatedCase).toEqual({
id: caseId,
data: payload.data,
data: {
field1: 'value1',
field2: 'value2',
},
});
});

Expand All @@ -484,12 +496,12 @@ describe('updateCase', () => {
const httpStub = {
get: (url) => {
expect(url).toEqual(`/cases/${caseId}/event-triggers/${eventId}`);
return Promise.resolve({data: {token}});
return Promise.resolve({data: {token, case_details: {case_data: {}}}});
},
post: (url, body) => {
expect(url).toEqual(`/cases/${caseId}/events`);
expect(body).toEqual({
data: undefined,
data: {},
event: {
id: eventId,
summary: undefined,
Expand Down