Skip to content

Conversation

@saghul
Copy link
Contributor

@saghul saghul commented Jan 6, 2026

Fixes: #1301
Fixes: #1302

@saghul
Copy link
Contributor Author

saghul commented Jan 6, 2026

No idea why TCC would fail... @bnoordhuis you likely have it ready to go, mind giving it a try?

@bnoordhuis
Copy link
Contributor

Atomic ops are disabled for tcc because they get miscompiled in (not so) recent versions, see 4871290. As a workaround, add something like below to tests.conf:

[features]
skip-if-tcc=!tcc

Then add a magic comment to the test file:

/*---
features: [skip-if-tcc]
---*/

@bnoordhuis
Copy link
Contributor

General observation (cc @Mcsky23): ideally tests for this get submitted to https://github.com/tc39/test262 because then it trickles down to all JS engines.

@saghul
Copy link
Contributor Author

saghul commented Jan 6, 2026

Atomic ops are disabled for tcc because they get miscompiled in (not so) recent versions, see 4871290. As a workaround, add something like below to tests.conf:

[features]
skip-if-tcc=!tcc

Then add a magic comment to the test file:

/*---
features: [skip-if-tcc]
---*/

Got it, will do!

@saghul saghul force-pushed the fix-atomic-ptr-access branch from c170fef to 55b5128 Compare January 6, 2026 23:03
@saghul saghul merged commit ea3e9d7 into master Jan 6, 2026
122 checks passed
@saghul saghul deleted the fix-atomic-ptr-access branch January 6, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heap use after free in js_atomics_op Heap use after free in js_atomics_store

3 participants