Fix timestamp reader in delete executor.#2116
Merged
Conversation
fmassot
deleted the
fmassot--fix-timestamp-reader-in-delete-executor--issues/2115
branch
guilload
reviewed
Oct 16, 2022
| rand = { workspace = true } | ||
| regex = { workspace = true } | ||
| serde = { workspace = true } | ||
| tantivy = { workspace = true } |
Member
There was a problem hiding this comment.
I'm really bummed that fastfield_codecs and tantivy were added as quickwit-common dependencies. Now, sub-crates that have nothing to do with tantivy pull those dependencies transitively. It really sucks when you do a cargo build/test -p quickwit-<...>, which I do a lot when developing to avoid compiling the whole project.
Collaborator
Author
There was a problem hiding this comment.
Yes, I was almost sure you will be annoyed by that :/
I'm opening an issue to move that, maybe in the doc mapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test updated to check it's fixed.