Skip to content

Unify merge & janitor max write throughput paramters into one paramet… #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmassot merged 2 commits into from
Nov 21, 2022
Merged

Unify merge & janitor max write throughput paramters into one paramet… #2360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d38eef
Unify merge & janitor max write throughput paramters into one paramet…
fmassot Nov 21, 2022
48bdcc9
Merge branch 'main' into fmassot--unify-max-write-throughput-config-p…
fmassot Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions quickwit/quickwit-config/src/index_config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,13 @@ pub struct IndexingResources {
pub __num_threads_deprecated: IgnoredAny, // DEPRECATED
#[serde(default = "IndexingResources::default_heap_size")]
pub heap_size: Byte,
/// Sets the maximum write IO throughput for the merge pipeline,
/// in bytes per secs. On hardware where IO is limited, this parameter can help limiting
/// the impact of merges on indexing.
/// Sets the maximum write IO throughput in bytes/sec for the merge and delete pipelines.
/// The IO limit is applied both to the downloader and to the merge executor.
/// On hardware where IO is limited, this parameter can help limiting the impact of
/// merges/deletes on indexing.
#[serde(default)]
#[serde(skip_serializing_if = "Option::is_none")]
pub max_merge_write_throughput: Option<Byte>,
/// Sets the maximum write IO throughput for the janitor, in bytes per secs.
/// On hardware where IO is limited, this parameter can help limiting
/// the impact on indexing.
#[serde(default)]
#[serde(skip_serializing_if = "Option::is_none")]
pub max_janitor_write_throughput: Option<Byte>,
}

impl PartialEq for IndexingResources {
Expand Down Expand Up @@ -113,7 +108,6 @@ impl Default for IndexingResources {
Self {
heap_size: Self::default_heap_size(),
max_merge_write_throughput: None,
max_janitor_write_throughput: None,
__num_threads_deprecated: IgnoredAny,
}
}
Expand Down
2 changes: 1 addition & 1 deletion quickwit/quickwit-janitor/src/actors/delete_task_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ impl DeleteTaskPipeline {
let throughput_limit: f64 = index_config
.indexing_settings
.resources
.max_janitor_write_throughput
.max_merge_write_throughput
.as_ref()
.map(|bytes_per_sec| bytes_per_sec.get_bytes() as f64)
.unwrap_or(f64::INFINITY);
Expand Down