Add validate_docs parameter to ingest settings#5984
Merged
Conversation
| /// Note that when a source has a VRL transform configured, documents are not validated against | ||
| /// the doc mapping during ingestion either. | ||
| #[schema(default = true, value_type = bool)] | ||
| #[serde(default = "true_fn", skip_serializing_if = "is_true")] |
Collaborator
There was a problem hiding this comment.
why skip_serializing_if? In most case it is better to serialize defaults no?
Here this is index config, so the data is deserialized -> serialized and end up in the metastore.
Serializing the default ensure changing default won't affect existing indexes, which is usually a good thing.
Member
Author
There was a problem hiding this comment.
I agree with you with one caveat: after adding a new field, if you have to rollback then the cluster is borked because of the deny_unknown_fields that we have. Maybe we should remove them and use serde_ignored instead to log a warning.
fulmicoton-dd
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
validate_docsparameter to ingest settings. Default totrue. We have a use case for this parameter at Datadog. This could also be used for OTEL indexes and by users who know that their documents are always well-formed to shave a few CPU cycles.How was this PR tested?
Updated index config unit tests