Merged
Conversation
guilload
commented
Nov 18, 2025
Contributor
trinity-1686a
left a comment
trinity-1686a
left a comment
There was a problem hiding this comment.
as is, updates that were idempotent no longer are, which has to be fixed before merging, but what's there seems good to me
guilload
force-pushed
the
guilload/validate-doc-mapping-update
branch
2 times, most recently
from
c5c310f to
598e857
Compare
guilload
force-pushed
the
guilload/validate-doc-mapping-update
branch
from
598e857 to
d54a2b2
Compare
trinity-1686a
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the doc mapping is validated at the metastore API level when an index config is updated.
How was this PR tested?