Add config to fail if search targets too many splits#6009
Merged
fulmicoton merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
fulmicoton
reviewed
Dec 17, 2025
| split_footer_cache_capacity: ByteSize::mb(500), | ||
| partial_request_cache_capacity: ByteSize::mb(64), | ||
| max_num_concurrent_split_searches: 100, | ||
| max_splits_per_search: None, |
Collaborator
There was a problem hiding this comment.
I'm surprised serializing tests are passing without having to update json files. Have we broken something?
Collaborator
There was a problem hiding this comment.
ah no. we don't have tests like that for node_config. That's ok then
fulmicoton
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a search needs to process too many splits compared to the cluster capacity, we know upfront that it is pretty much impossible for the query to succeed. Instead of trusting resources for the whole duration of the configured timeout, this PR adds a node config to cancel these requests early (after the planning but before sending the jobs to the leafs).
How was this PR tested?
Unit test