Merged
Conversation
congx4
commented
Dec 22, 2025
quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs
Outdated
Show resolved
Hide resolved
guilload
requested changes
Dec 23, 2025
Member
guilload
left a comment
guilload
left a comment
There was a problem hiding this comment.
Your PR works but it can be greatly simplified.
quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks for the suggestion! |
guilload
approved these changes
Dec 23, 2025
Member
guilload
left a comment
guilload
left a comment
There was a problem hiding this comment.
Approved but can simplify this further.
quickwit/quickwit-storage/src/opendal_storage/google_cloud_storage.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/merge |
nico34638
pushed a commit
to nico34638/quickwit
that referenced
this pull request
Jan 5, 2026
* fix gcs tests * update the gcs tests * remove comments * add default impl * fix fmt * address comments * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the integration test for gcs storage where reported here.
https://github.com/quickwit-oss/quickwit/actions/runs/20378291223/job/58562301680
How was this PR tested?
run the command
RUST_MIN_STACK=67108864 CARGO_BUILD_JOBS=4 cargo llvm-cov nextest --no-report --all-features --no-fail-fast --retries 4that runs during code coverage. google_cloud_storage_test_suite test is successful now.