Always refill permits on rate limiter; use governor clock instead of std#6133
Merged
nadav-govari merged 1 commit intomainfrom Jan 30, 2026
Merged
Always refill permits on rate limiter; use governor clock instead of std#6133nadav-govari merged 1 commit intomainfrom
nadav-govari merged 1 commit intomainfrom
Conversation
guilload
approved these changes
Jan 30, 2026
8f4f71f to
c80a5a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
available_permits()didn't actually supply an accurate portrayal of capacity, as enough time may have elapsed that a refill is needed. So now a refill is automatically triggered on any call toavailable_permits()oracquire().Additionally, the
governorcrate has a custom implementation of a clock that is faster than std::time. I benchmarked it as follows:With the following results:
Seeing as the benchmark itself used Instant::now, this is probably not scientific, but at these latencies this doesn't really matter.
I went with the default governor clock seeing as an OS thread updating every millisecond is overkill, and the speed of this is not going to contribute to any meaningful bottlenecks enough to optimize this further.