Merged
Conversation
trinity-1686a
changed the title
Member
|
We're doing this because of rate limiting, right? If so, can we properly catch the error and infer it is due to rate limiting? If so, we can build a FIFO queue instead and retry with exponential backoff blabla? That would allow us to better handle dynamic quotas that AWS raise automatically based on usage. |
trinity-1686a
force-pushed
the
trinity.pointard/lambda-improvements
branch
2 times, most recently
from
8780e20 to
b757ce4
Compare
trinity-1686a
force-pushed
the
trinity.pointard/lambda-improvements
branch
from
b757ce4 to
93fa11e
Compare
guilload
approved these changes
Mar 3, 2026
| let searcher_context = if node_config.is_service_enabled(QuickwitService::Searcher) { | ||
| if let Some(lambda_config) = &node_config.searcher_config.lambda { | ||
| info!("initializing AWS Lambda invoker for search"); | ||
| warn!("offloading to lambda is EXPERIMENTAL. Use at your own risk"); |
Member
There was a problem hiding this comment.
Unsure customers are going to like this warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a concurrency limiter to lambda invocation, and make lambda support optional