Redact sensitive information in developer API debug output. Closes #6132#6191
Merged
guilload merged 3 commits intoquickwit-oss:mainfrom Mar 5, 2026
Conversation
Contributor
Author
|
@guilload would you have time to review? Quick security hardening for the debug API. |
guilload
approved these changes
Mar 4, 2026
Member
|
Awesome, thanks @osyniakov |
Contributor
Author
|
@guilload thanks for the quick review. Could you merge when you have a moment? I don't have merge rights. The branch is updated from main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #6132 by redacting sensitive data on the developer debug API endpoint (/api/developer/debug).
Previously, the endpoint returned the full node config (including metastore connection strings with credentials, S3 secret keys, Azure access keys, etc.) in plain text. The same redaction logic used for the node config REST endpoint (/api/v1/config) is now applied here.
How was this PR tested?
Unit test.