Add az-awareness to ingest metrics#6194
Merged
nadav-govari merged 5 commits intonadav/pr6from Mar 5, 2026
Merged
Conversation
nadav-govari
added a commit
that referenced
this pull request
Mar 9, 2026
* Add metrics for az-aware ingest * finally fix that lint issue * emit a simple metric instead * rename * lints
nadav-govari
added a commit
that referenced
this pull request
Mar 9, 2026
* Add metrics for az-aware ingest * finally fix that lint issue * emit a simple metric instead * rename * lints
nadav-govari
added a commit
that referenced
this pull request
Mar 9, 2026
* Remove old routing table; Take both disk and memory WAL readings * Add az-aware ingest attempts metric (#6194)
nadav-govari
added a commit
that referenced
this pull request
Mar 16, 2026
* Implement IngesterCapacityScore broadcast (#6152) * Implement node based routing table (#6159) * Use new node based routing table for routing decisions (#6163) * Piggyback routing update on persist response (#6173) * Remove unused shard_ids in persist protos (#6169) * Add availability zone awareness to node based routing (#6189) * Remove old routing table; Take both disk and memory WAL readings (#6193) * Add az-aware ingest attempts metric (#6194)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't super love this change but it's the least intrusive way to get an az locality tag on the persist persist results metric.
update_ingest_metricsfires after all of the subrequests have finished and only operates on the proto, so without completely refactoring ingest metrics, the best way to emit this was by just putting it on the proto. its fairly harmless but its not the ideal way to do this.How was this PR tested?
Tests.