Ensure zlib buffer is closed before writing objects to storage #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobowers
approved these changes
Apr 2, 2020
tobowers
left a comment
tobowers
left a comment
There was a problem hiding this comment.
this particular code looks good to me, but I'm not positive I have a full context, but this change looks nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the skynet objects were only getting the zlib header because the
defer writer.Close()wasn't triggering till after the skynet upload call. This ensures the buffer is always called by pulling it out into its own method, used in both chaintree and sia stores, and then adds a test (which fails without the close).