Skip to content

Fix for pptpsetup without specifing --password parameter#2

Open
franzo15 wants to merge 1 commit intoquozl:masterfrom
franzo15:master
Open

Fix for pptpsetup without specifing --password parameter#2
franzo15 wants to merge 1 commit intoquozl:masterfrom
franzo15:master

Conversation

@franzo15
Copy link
Copy Markdown

@franzo15 franzo15 commented Apr 3, 2020

Use also perl module Term::ReadKey in order to prevent display the password in clear text

Use also perl module Term::ReadKey in order to prevent display the password in clear text
@quozl
Copy link
Copy Markdown
Owner

quozl commented Apr 5, 2020

Thanks. Reviewed.

  • removal of trailing whitespace has been lost, f449742,
  • accept passwords with quotes has been lost, e62bfa7,
  • indentation style has changed, inconsistent within file,
  • version changed but no explanation in commit message; it hasn't changed since 2006, does this mean you taking on responsibility to maintain this? I've been thinking of removing pptpsetup for the next release, now that Network Manager deals with configuration on desktop systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants