Conversation
TheKrol
approved these changes
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds three new factoid properties:
Disabled
Protected
Restricted
Disabled completely disables a factoid from being called, but keeps it in the database
Protected prevents all edit attempts on a factoid until it is first unprotected
Restricted only allows factoids to be called from a predefined list of channels
This also moves those 3 properties, and hidden, to be only controllable by a factoids admins set of roles
This changes the way the factoids permissions checks work, and the way modifying factoids work to make the code a bit cleaner and easier to read.
Additionally, .factoid info now shows a "properties" tab that will show the 4 special factoid properties, replacing the existing hidden tab.