Add Context Menu command for Whois#868
Conversation
|
The /whois command has the following check: @app_commands.check(is_reader)But since the context menu command is run differently, this doesn't work there The is_reader function should be removed from the app_commands.check and moved into the get_note_command, so it checks equally on both the context menu and slash command calls Additionally, can you add an empty line at the bottom of the .gitignore file? |
74c4652 to
8700ae8
Compare
TheKrol
left a comment
There was a problem hiding this comment.
Doesn't work with no reader set.
|
I still don't understand why the test is failing
On Friday, July 05, 2024 11:00 PDT, ajax146 ***@***.***> wrote:
@dkay0670 @TheKrol What is the status on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#868 (comment)", "url": "#868 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***>
|
|
nvm wrong pr, I just need to fix it, I'll set myself a reminder |
|
You should just ignore the test on the other one, I am reworking all the tests, to make them actually useful. It will fix the problem |
|
closing since this whole file will be gone after #1095 gets merged. will try and implement this with the new code |
Add Context Menu command for Whois