Avoid splicing eagerly in bench::mark()

DESCRIPTION

@@ -18,7 +18,7 @@ Imports:
     profmem,
     rlang (>= 0.2.0),
     stats,
-    tibble,
+    tibble (>= 3.0.1),
     utils
 Suggests:
     covr,
@@ -38,4 +38,4 @@ Suggests:
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.0.2
+RoxygenNote: 7.1.0

NEWS.md

@@ -1,5 +1,9 @@
 # bench (development version)
 
+* `bench::mark()` and `bench::workout()` no longer support unquote
+  and splice operators. This fixes inconsistencies in performance
+  results with functions like `rlang::list2()` (#61).
+
 * `autoplot.bench_mark()` again supports factor levels for `expression`, as intended (#82)
 
 # bench 1.1.1

R/mark.R

@@ -58,7 +58,7 @@ mark <- function(..., min_time = .5, iterations = NULL, min_iterations = 1,
   }
 
   if (is.null(exprs)) {
-    exprs <- rlang::exprs(...)
+    exprs <- dots(...)
   }
 
   n_exprs <- length(exprs)
@@ -130,7 +130,7 @@ mark <- function(..., min_time = .5, iterations = NULL, min_iterations = 1,
     results$gc[[i]] <- parse_gc(gc_msg)
   }
 
-  out <- summary(bench_mark(tibble::as_tibble(results, validate = FALSE)),
+  out <- summary(bench_mark(tibble::as_tibble(results, .name_repair = "minimal")),
           filter_gc = filter_gc, relative = relative, time_unit = time_unit)
 
   file <- getOption("bench.file", NULL)

R/utils.R

@@ -122,3 +122,14 @@ find_package_root <- function(path) {
 is_root <- function(path) {
   identical(path, dirname(path))
 }
+
+dots <- function(...) {
+  dots <- as.list(substitute(...()))
+
+  n <- length(dots)
+  if (n && rlang::is_missing(dots[[n]])) {
+    dots <- dots[-n]
+  }
+
+  dots
+}

R/workout.R

@@ -24,12 +24,12 @@
 #' # The equivalent to the above, reading the code from a file
 #' workout_expressions(as.list(parse(system.file("examples/exprs.R", package = "bench"))))
 workout <- function(expr, description = NULL) {
-  expr <- rlang::enquo(expr)
-  env <- rlang::quo_get_env(expr)
-  if (rlang::quo_get_expr(expr)[[1]] == "{") {
-    exprs <- as.list(rlang::quo_get_expr(expr)[-1])
+  expr <- substitute(expr)
+  env <- parent.frame()
+  if (rlang::is_call(expr, "{")) {
+    exprs <- as.list(expr[-1])
   } else {
-    exprs <- list(rlang::quo_get_expr(expr))
+    exprs <- list(expr)
   }
   workout_expressions(exprs, env, description)
 }