Attempt S4 dispatch for intersect() and union(), maybe - alternative 2#308
Open
Attempt S4 dispatch for intersect() and union(), maybe - alternative 2#308
Conversation
Collaborator
Author
|
I have to look into the last test case regarding S3 in test-setops64. It runs without errors locally, but throws an error here. |
Collaborator
Author
|
I have tested it with nanotime locally and it worked as expected for the testcases I had. Does it work for your test cases and with nanotime? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further approach to address #301. It is based on #305.
I tested it with first loading nanotime and then bit64 and vice versa.
The tests have to be refactored.