Merged
Conversation
We can test and document devtools's use of pak without doing any sysreq stuff, which is what the `sudo` probe relates to.
jennybc
requested review from
Copilot and
hadley
and removed request for
Copilot
Member
Author
|
The ❌ shows that we can detect 
|
hadley
approved these changes
Mar 13, 2026
Member
Author
|
Related: I also opened r-lib/pak#850. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devtools's new use of pak can potentially indirectly execute
can_sudo_without_pw(), which is basically doing some pre-checks in case sysreq work is needed. However testing and documenting devtools would never actually need to do such sysreq tasks. We should never ticklesudothis way. The new GHA workflow is intended to make sure this stays fixed.https://github.com/r-lib/pak/blob/cda86c5ceea65d23f2facb70303347d8e09f4081/src/library/pkgdepends/R/sysreqs.R#L567