callr::rcmd_process_options: use libpath argument#212
Open
pawelru wants to merge 1 commit intor-lib:mainfrom
Open
callr::rcmd_process_options: use libpath argument#212pawelru wants to merge 1 commit intor-lib:mainfrom
callr::rcmd_process_options: use libpath argument#212pawelru wants to merge 1 commit intor-lib:mainfrom
Conversation
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix r-lib/rcmdcheck#236
I still got error regarding the libpath and the r-lib/rcmdcheck#196 was not enough.
rcmdcheckpass the libpaths correctly but it is not picked up insidepkgbuild(and the default libpath is used instead).I does fix my use case. @gaborcsardi please check if this fixes yours and let me know if anything is needed from my side!