Skip to content

Use cleancall to solve a file descriptor leak#238

Merged
gaborcsardi merged 2 commits into
masterfrom
cleancall
Feb 7, 2020
Merged

Use cleancall to solve a file descriptor leak#238
gaborcsardi merged 2 commits into
masterfrom
cleancall

Conversation

@gaborcsardi
Copy link
Copy Markdown
Member

We can use it for better resource cleanup in general.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2020

Codecov Report

Merging #238 into master will decrease coverage by 1.82%.
The diff coverage is 69.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   75.59%   73.77%   -1.83%     
==========================================
  Files          36       32       -4     
  Lines        3749     2955     -794     
==========================================
- Hits         2834     2180     -654     
+ Misses        915      775     -140
Impacted Files Coverage Δ
src/init.c 100% <100%> (ø) ⬆️
R/process.R 78.44% <100%> (-2.77%) ⬇️
R/cleancall.R 100% <100%> (ø)
R/errors.R 81.31% <45.45%> (-4.94%) ⬇️
src/cleancall.c 70.31% <70.31%> (ø)
R/utils.R 59.5% <0%> (-25.62%) ⬇️
src/client.c 36.61% <0%> (-19.17%) ⬇️
src/create-time.c 50% <0%> (-18.58%) ⬇️
R/run.R 82.12% <0%> (-10.06%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c35b0...d328de2. Read the comment docs.

@gaborcsardi gaborcsardi merged commit e6bc865 into master Feb 7, 2020
@gaborcsardi gaborcsardi deleted the cleancall branch February 7, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants