Merged
Conversation
On Linux, `process$get_start_time()` now returns the correct wall-clock start time. Previously it was systematically ~0.3–0.5 s too early because the boot time was read from `/proc/stat btime`, which is truncated to whole seconds. processx now derives the boot time from `CLOCK_REALTIME − CLOCK_MONOTONIC`, which has nanosecond precision. The ps package is updated in tandem to accept handles created by either the old or the new method, so new ps + old processx continues to work (#394, #402). Closes #394, closes #402.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux,
process$get_start_time()now returns the correct wall-clock start time. Previously it was systematically ~0.3–0.5 s too early because the boot time was read from/proc/stat btime, which is truncated to whole seconds. processx now derives the boot time fromCLOCK_REALTIME − CLOCK_MONOTONIC, which has nanosecond precision. The ps package is updated in tandem to accept handles created by either the old or the new method, so new ps + old processx continues to work (#394, #402).Closes #394, closes #402.