Speed improvement in caching #679
Merged
lorenzwalthert merged 6 commits intor-lib:masterfrom Nov 1, 2020
Merged
Conversation
d8e5ff2 to
dccfa72
Compare
dccfa72 to
18b4fd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 90.43% 90.42% -0.01%
==========================================
Files 47 47
Lines 2226 2225 -1
==========================================
- Hits 2013 2012 -1
Misses 213 213
Continue to review full report at Codecov.
|
7cac0f1 to
d0ff48a
Compare
d0ff48a to
912eec7
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't convert transformers to character. We have version and name, this is sufficient. Goal is also to see if this is reflected in continuous benchmarking.
dccfa
6535ba1 (wait: 0.003)
7cac0f1 (wait: 0.004)
75176a6
Major speed improvements are expected for
cache_appylingandcache_recording, butwithout_cacheshould not change at all but is 5% slower.