Skip to content

Coerce comments #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edzer merged 2 commits into from
Jan 10, 2023
Merged

Coerce comments #2079

edzer merged 2 commits into from
Jan 10, 2023

Conversation

@rsbivand
Copy link
Member

@rsbivand rsbivand commented Jan 9, 2023 •
edited
Loading

This should work with older GEOS; not checked for lwgeom for #2069 . Looks like

CAPI: GEOSMakeValidWithParams new validity enforcement approach from locationtech/jts#704, uses GeometryFixer (Paul Ramsey, Martin Davis)

https://github.com/libgeos/geos/blob/3.11.1/NEWS.md in 3.10.0.

@rsbivand rsbivand changed the title Coerce comments #2069 Coerce comments Jan 9, 2023
@edzer edzer merged commit 2371141 into r-spatial:main Jan 10, 2023
@rsbivand
Copy link
Member Author

rsbivand commented Jan 10, 2023

Maybe comment out

sf/tests/testthat/test_sp.R

Line 27 in 5334d9c

skip_if_not(package_version(sf_extSoftVersion()["GEOS"]) >= "3.11.0")
, as with the fix the test also passes on earlier GEOS?

edzer added a commit that referenced this pull request Jan 10, 2023
@edzer
remove skip; #2079
f8b740d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsbivand @edzer