Change private key loading to default to PEM-encoded PKCS#8#138
Open
bdj wants to merge 1 commit intoracket:masterfrom
Open
Change private key loading to default to PEM-encoded PKCS#8#138bdj wants to merge 1 commit intoracket:masterfrom
bdj wants to merge 1 commit intoracket:masterfrom
Conversation
Author
|
Is there anything else that needs to be done here to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler change to support LetsEncrypt keys in the webserver. See #137 for more discussion. If someone has better copy for the documentation, I would be happy to change it. I have tested this for my use case and it works, but I would also be willing to add tests if there is a good way to test this.
cc @LiberalArtist @rmculpepper