Docs/update 20260109 1810#25
Open
racmac57 wants to merge 2 commits into
Open
Conversation
- Fixed OneDrive file detection by adding -Force parameter to Get-ChildItem calls - Added automatic filtering to skip .origin.json manifest files during processing - Implemented multi-method file detection (Test-Path, System.IO fallback) - Enhanced error reporting and debugging output - Created cleanup_origin_files.ps1 utility script - Updated documentation (README, SUMMARY, CHANGELOG) with OneDrive integration details - Added Chunker_MoveOptimized.bat for Windows SendTo menu integration Resolves issue where OneDrive-synced files were not detected due to reparse points and prevents infinite loops when manifest files are accidentally selected.
…ation and watcher stability Moved Unreleased entries to v2.1.12 release with date 2026-01-09 Updated version in package.json to 2.1.12 Updated README.md and SUMMARY.md to reflect v2.1.12 changes Refs: ef0b422 Affects: CHANGELOG.md, README.md, SUMMARY.md, package.json
racmac57
commented
Jan 9, 2026
Owner
Author
racmac57
left a comment
racmac57
left a comment
There was a problem hiding this comment.
Review Summary
This PR provides comprehensive documentation updates for v2.1.12, focusing on OneDrive integration improvements and watcher stability enhancements. The changes look good overall.
✅ Strengths
- Comprehensive CHANGELOG: Well-documented changes with clear categorization (Added, Fixed, Planned, Links)
- OneDrive Integration: Robust file detection improvements with:
- Multi-method file detection (Test-Path, System.IO.File, System.IO.Directory)
- Proper handling of reparse points and cloud files using
-Forceparameter - Automatic manifest filtering to prevent infinite loops
- Error Handling: Good retry logic (3 attempts) for OneDrive file removal with appropriate sleep intervals
- Path Handling: Improved path reconstruction logic to handle spaces in filenames
- New Utilities: Added
cleanup_origin_files.ps1for cleaning up metadata files - Documentation: Updated README and SUMMARY with clear instructions
📝 Minor Suggestions
- Hardcoded Path (cleanup_origin_files.ps1:4): The desktop path is hardcoded. Consider using
$env:USERPROFILEor accepting a parameter for flexibility. - Version Consistency: Package.json version updated from 1.0.0 to 2.1.12 - good catch!
✅ Recommendation
APPROVE - This is a solid documentation update with meaningful improvements to OneDrive integration. All tests are passing, and the changes are well-documented.
Good work on the comprehensive changelog and improved error handling!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test
Checklist