test(job_integrity): grow fixture content above MIN_ARTIFACT_BYTES#36
Merged
Conversation
The complete_job fixture and test_failure_with_retry_success wrote artifact files of 21-42 bytes while job_integrity.validate_artifact enforces min_bytes: 50 for chunks, transcript, sidecar, and manifest. These tests therefore failed deterministically on every CI run: - TestValidation.test_validate_complete_job - TestIntegrationScenarios.test_complete_successful_workflow - TestIntegrationScenarios.test_failure_with_retry_success Pad each fixture payload so every generated file exceeds the 50-byte threshold (range 57-81 bytes). No production code change; no assertion change; only test inputs.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three tests in
tests/test_job_integrity.pyfailed deterministically on every CI run because the fixture content was smaller than the validator's minimum size:TestValidation.test_validate_complete_jobTestIntegrationScenarios.test_complete_successful_workflowTestIntegrationScenarios.test_failure_with_retry_successjob_integrity.pyenforcesmin_bytes: 50for chunks, transcript, sidecar, and manifest (lines 30–33). Thecomplete_jobfixture and the retry test wrote files of 21–42 bytes — guaranteed to fail validation.Change
Pad each fixture payload so every generated file exceeds 50 bytes (new range: 57–81 bytes). No production code change. No assertion change. Only test inputs.
Why this matters now
Unrelated PR #35 (vite Dependabot alert) cannot merge on green CI while this test is broken. Fixing the fixtures unblocks #35 and any future Dependabot PRs.
Test plan