ci+docs: ruff blocking lint, Windows runbook, script audit#50
Merged
Conversation
Added linter configuration for chunker_Web with specific rules and exclusions.
…able) This document outlines the manual verification process for Windows-side CI rows, including preconditions, tests, expected outputs, and result recording.
The previous two commits on this branch shipped files with cascading indent corruption. yaml.safe_load rejects ci.yml outright, so GitHub silently skipped this workflow — that's why only the `automerge` job appeared on PR #50 and `test-fast` never ran. Merging as-is would have overwritten the working ci.yml on main and disabled CI repo-wide. - .github/workflows/ci.yml: rewritten from the post-#43 main baseline, with `continue-on-error: true` removed from the Lint (ruff) step (the one intended change of this PR). - ruff.toml: rewritten with clean indentation and an ignore list that actually covers every rule currently tripped by the repo (E402/E501/E722/E741/F401/F541/F811/F821/F841/W292). `ruff check .` now reports "All checks passed!" on HEAD. F821 stays ignored deliberately — it flags 4 pre-existing latent bugs (missing imports of TaskCoordinator / process_file_task in enhanced_watchdog.py and an undefined module-level `config` in langchain_rag_handler.py). Those want their own PR; removing F821 from the ignore list without fixing them would break this step immediately. Follow-up (separate PRs): * fix the 4 F821 sites * shrink the ignore list (118 of 210 findings auto-fix with `ruff check --fix`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three lower-urgency items requested by Claude Code after PR #43 landed and CI went green.
Task 1 — Promote ruff to blocking
ruff.tomlwith a curated baseline config (E + F rules, legacy dirs excluded, per-file ignores for test files)continue-on-error: truefrom the "Lint (ruff)" step inci.yml— style breakage now blocks mergesTask 2 — Windows shakedown runbook
docs/WINDOWS_SHAKEDOWN_RUNBOOK.mdwith step-by-step instructions for the 4 unverified Windows-side rows:Task 3 — Script audit (informational, no file changes)
See audit findings below. No files moved in this PR; archival is a follow-up.
Script Audit Findings
Live / npm-surface scripts (keep as-is):
Start-Watcher.ps1/Start-Watcher.bat/Start-Watcher-Silent.bat— active watcher lifecycleStop-Watcher.ps1/Stop-Watcher.bat— active watcher lifecycleKB-Health.ps1—npm run kb:healthSmoke-Test.ps1—npm run kb:smokeArchive-ChunkerLogs.ps1— occasional log rotationRegister-ChunkerWatcherAtLogon.ps1/.bat—npm run kb:register:watcherRegister-DeduperTask.ps1—npm run kb:register:dedupeRun-WeeklyDedupe.ps1— called byKB_Weekly_Dedupe.xmlUtility / situational (keep but not on npm surface):
Check-ScheduledTasks.ps1— diagnosticsCleanup-DuplicateTasks.ps1/.bat— one-time dedup of duplicate tasks; keep for referenceRegister-Watcher-StartupTask.ps1— older startup-task script; superseded byRegister-ChunkerWatcherAtLogon.ps1but kept for referenceFind-And-Fix-Recursive-Paths.ps1/Fix-OneDrive-Sync.ps1— OneDrive incident toolsUpdate-Docs-And-Release.ps1/gh_gql.ps1/release_commit_and_tag.bat— release automationValidate-Departments.py— one-off validationDead / archivable (follow-up PR):
desktop.ini— Windows Explorer metadata, no function in repoQUICK_START_CORRECTED.md— superseded byREADME_SCRIPTS.md_archived/directory contents — already archived; can be pruned