Skip to content

Remove paths filter from spellcheck PR trigger#96

Merged
DariuszPorowski merged 1 commit into
mainfrom
copilot/update-spellcheck-path-filter
May 14, 2026
Merged

Remove paths filter from spellcheck PR trigger#96
DariuszPorowski merged 1 commit into
mainfrom
copilot/update-spellcheck-path-filter

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

Some Dependabot PRs are blocked because the Spellcheck workflow is a required check via branch protection, but it has a paths filter on the pull_request trigger. When a PR doesn't touch any of the filtered paths, the workflow doesn't run and the required check never reports a status, leaving the PR stuck (e.g. #95).

This removes the paths filter from the pull_request trigger in .github/workflows/spellcheck.yaml so the workflow runs on every PR targeting main and the required check always reports a status. The push trigger's paths filter is left intact.

Agent-Logs-Url: https://github.com/radius-project/blog/sessions/0e87d70a-b6ef-4444-abe2-c5d446a5ad82

Co-authored-by: brooke-hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Spellcheck GitHub Actions workflow to ensure it always runs (and reports a status) on pull requests targeting main, preventing branch protection from blocking PRs when the workflow is skipped due to paths filters.

Changes:

  • Removed the paths filter from the pull_request trigger in .github/workflows/spellcheck.yaml.
  • Left the push trigger’s paths filter intact so push-based runs remain scoped to relevant files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

Static Web App Preview

Environment Deployment
pr96 View workflow run

Deployed from commit 75826d37a9ad88fee02c025aa5db669e824f1a1f via the publisher workflow.

@DariuszPorowski DariuszPorowski merged commit 1f8ec7a into main May 14, 2026
11 checks passed
@DariuszPorowski DariuszPorowski deleted the copilot/update-spellcheck-path-filter branch May 14, 2026 18:04
Copy link
Copy Markdown
Member

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants