Feature specs: `Applications.Core/secretStores` extended use cases by willtsai · Pull Request #57 · radius-project/design-notes

willtsai · 2024-07-26T23:03:22Z

Here are the feature specs for extending the use cases of Applications.Core/secretStores

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

superbeeny

Looks good, just have the one question around naming conventions for types.

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

github-actions · 2024-08-20T00:19:03Z

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions · 2024-08-27T00:19:25Z

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

github-actions · 2024-10-01T00:23:43Z

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions · 2024-10-09T00:21:22Z

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

github-actions · 2025-01-09T00:21:39Z

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

…design-notes-radius into secret-store-scenarios

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

nithyatsu

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

willtsai · 2025-01-24T19:19:17Z

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

This feature spec should not affect how we store AZ and AWS secrets, thanks for checking though!

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

github-actions · 2025-02-08T00:20:50Z

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

willtsai · 2025-02-13T19:03:44Z

still waiting on another round of reviews

kachawla

Thanks for the updates - looks great! Left a few clarifying comments.

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

willtsai added 3 commits July 26, 2024 16:01

add secret store scenario extension feature specs

d758e9f

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

spelling corrections

1338afe

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

spelling corrections

c0ebedb

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

rynowak reviewed Jul 29, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

rynowak reviewed Jul 29, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

superbeeny reviewed Jul 31, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

Merge branch 'main' into secret-store-scenarios

dfda0b0

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

rynowak reviewed Aug 1, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md

rynowak reviewed Aug 1, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

rynowak reviewed Aug 1, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

willtsai added 3 commits August 1, 2024 15:39

add content

443523e

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

add content

6131515

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

address feedback on proposed examples

38a8ee3

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

github-actions Bot added the Stale label Aug 20, 2024

github-actions Bot closed this Aug 27, 2024

willtsai reopened this Sep 16, 2024

kachawla reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

kachawla reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

kachawla reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md

brooke-hamilton reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

kachawla reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

kachawla reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

lakshmimsft reviewed Sep 16, 2024

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md

github-actions Bot removed the Stale label Sep 17, 2024

brooke-hamilton mentioned this pull request Sep 24, 2024

REQUEST: New membership for brooke-hamilton radius-project/community#51

Closed

4 tasks

github-actions Bot added the Stale label Oct 1, 2024

github-actions Bot added the Stale label Jan 1, 2025

github-actions Bot closed this Jan 9, 2025

willtsai reopened this Jan 16, 2025

github-actions Bot removed the Stale label Jan 17, 2025

willtsai added 6 commits January 16, 2025 16:42

address review feedback

247b915

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

Merge branch 'main' into secret-store-scenarios

41572d4

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

address review feedback

bfaa9ce

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

Merge branch 'secret-store-scenarios' of https://github.com/willtsai/…

d69fc19

…design-notes-radius into secret-store-scenarios

spellcheck fixes

0168874

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

spellcheck fixes

ded7018

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

ytimocin reviewed Jan 21, 2025

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

nithyatsu reviewed Jan 21, 2025

View reviewed changes

sylvainsf reviewed Jan 21, 2025

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

willtsai added 2 commits January 22, 2025 17:30

address feedback from Jan 21

3be6c66

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

address feedback from Jan 21

3237400

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

willtsai added 2 commits January 24, 2025 15:20

add dapr and udt use cases

85a24ff

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

add dapr and udt use cases

799c6c2

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

github-actions Bot added the Stale label Feb 8, 2025

willtsai removed the Stale label Feb 10, 2025

brooke-hamilton approved these changes Feb 19, 2025

View reviewed changes

kachawla reviewed Mar 5, 2025

View reviewed changes

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

Comment thread resources/2024-07-secretstore-feature-spec.md Outdated

willtsai added 2 commits March 5, 2025 20:38

address feedback from 20250305

65fc0c4

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

Merge branch 'main' into secret-store-scenarios

320a690

kachawla approved these changes Mar 6, 2025

View reviewed changes

willtsai merged commit 7e1d737 into radius-project:main Mar 6, 2025

willtsai deleted the secret-store-scenarios branch March 6, 2025 18:01

Conversation

willtsai commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

superbeeny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 20, 2024

Uh oh!

github-actions Bot commented Aug 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2024

Uh oh!

github-actions Bot commented Oct 9, 2024

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

Uh oh!

nithyatsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

willtsai commented Jan 24, 2025

Uh oh!

github-actions Bot commented Feb 8, 2025

Uh oh!

willtsai commented Feb 13, 2025

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants