Skip to content

Superbeeny/adding podspec secrets#1100

Merged
willtsai merged 5 commits into
radius-project:v0.32from
superbeeny:superbeeny/adding-podspec-secrets
Apr 5, 2024
Merged

Superbeeny/adding podspec secrets#1100
willtsai merged 5 commits into
radius-project:v0.32from
superbeeny:superbeeny/adding-podspec-secrets

Conversation

@superbeeny
Copy link
Copy Markdown
Contributor

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Adding example for the how-to's showing how to use podspec to inject secrets as environment variables into the container.

Issue reference

Based on conversation in discord

… environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
@superbeeny
Copy link
Copy Markdown
Contributor Author

Fixes #1101

@willtsai
Copy link
Copy Markdown
Contributor

willtsai commented Apr 4, 2024

Thanks @superbeeny! I will give this a review here within the next day.

Copy link
Copy Markdown
Contributor

@willtsai willtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you for adding this How-To Guide. I've left some minor suggestions, please take a look and let me know if you have any questions.

Comment thread docs/content/guides/author-apps/kubernetes/how-to-access-secrets/index.md Outdated
Comment thread docs/content/guides/author-apps/kubernetes/how-to-access-secrets/index.md Outdated
Comment thread docs/content/guides/author-apps/kubernetes/how-to-access-secrets/index.md Outdated
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@willtsai willtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for addressing the feedback!

@willtsai willtsai merged commit 78acb76 into radius-project:v0.32 Apr 5, 2024
willtsai added a commit that referenced this pull request Apr 25, 2024
* Update docs for v0.32.0

* Update environment logic (#1097)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Superbeeny/adding podspec secrets (#1100)

* Adding example on how to access secrets and add them to the container environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Adding code tabs where the commands differ between linux/windows

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Updates requested from PR review

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* nit: add a new line for spacing aesthetics

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1102)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* fix(bug): Update index.md (#1113)

* fix(bug): Update index.md

Fixed a bug in the cleanup script.

The command `rad app delete demo -y`
results in this output:
`Application 'demo' does not exist or has already been deleted.`

The command should be:
`rad app delete -y`
The output will be:
`Application first-app deleted`

Signed-off-by: Loek Duys <loekd@hotmail.com>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Fix broken link in faq (#1112)

* fix broken link in index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update docs/content/concepts/faq/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* add Connections crosslinks to Existing app tutorial (#1103)

* add Connections crosslinks to Existing app tutorial

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add more crosslinks

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
willtsai added a commit that referenced this pull request Apr 25, 2024
* Update docs for v0.32.0

* Update environment logic (#1097)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Superbeeny/adding podspec secrets (#1100)

* Adding example on how to access secrets and add them to the container environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Adding code tabs where the commands differ between linux/windows

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Updates requested from PR review

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* nit: add a new line for spacing aesthetics

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1102)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* fix(bug): Update index.md (#1113)

* fix(bug): Update index.md

Fixed a bug in the cleanup script.

The command `rad app delete demo -y`
results in this output:
`Application 'demo' does not exist or has already been deleted.`

The command should be:
`rad app delete -y`
The output will be:
`Application first-app deleted`

Signed-off-by: Loek Duys <loekd@hotmail.com>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Fix broken link in faq (#1112)

* fix broken link in index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update docs/content/concepts/faq/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* update gh to ado sync workflow to use service principals

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add Connections crosslinks to Existing app tutorial (#1103)

* add Connections crosslinks to Existing app tutorial

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add more crosslinks

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update config.toml

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
willtsai added a commit that referenced this pull request Jun 10, 2024
* Update docs for v0.33.0

* update gh to ado sync workflow to use service principals (#1118)

* Update docs for v0.32.0

* Update environment logic (#1097)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Superbeeny/adding podspec secrets (#1100)

* Adding example on how to access secrets and add them to the container environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Adding code tabs where the commands differ between linux/windows

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Updates requested from PR review

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* nit: add a new line for spacing aesthetics

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1102)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* fix(bug): Update index.md (#1113)

* fix(bug): Update index.md

Fixed a bug in the cleanup script.

The command `rad app delete demo -y`
results in this output:
`Application 'demo' does not exist or has already been deleted.`

The command should be:
`rad app delete -y`
The output will be:
`Application first-app deleted`

Signed-off-by: Loek Duys <loekd@hotmail.com>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Fix broken link in faq (#1112)

* fix broken link in index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update docs/content/concepts/faq/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* update gh to ado sync workflow to use service principals

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add Connections crosslinks to Existing app tutorial (#1103)

* add Connections crosslinks to Existing app tutorial

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add more crosslinks

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update config.toml

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>

* Update index.md (#1121)

Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup`

(added missing `-`)

Signed-off-by: Loek Duys <loekd@hotmail.com>

* add new logo types (#1122)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Add CNCF website guidelines (#1123)

* Add copyrights

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

---------

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
willtsai added a commit that referenced this pull request Jun 18, 2024
* Update docs for v0.33.0

* update gh to ado sync workflow to use service principals (#1118)

* Update docs for v0.32.0

* Update environment logic (#1097)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Superbeeny/adding podspec secrets (#1100)

* Adding example on how to access secrets and add them to the container environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Adding code tabs where the commands differ between linux/windows

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Updates requested from PR review

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* nit: add a new line for spacing aesthetics

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1102)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* fix(bug): Update index.md (#1113)

* fix(bug): Update index.md

Fixed a bug in the cleanup script.

The command `rad app delete demo -y`
results in this output:
`Application 'demo' does not exist or has already been deleted.`

The command should be:
`rad app delete -y`
The output will be:
`Application first-app deleted`

Signed-off-by: Loek Duys <loekd@hotmail.com>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Fix broken link in faq (#1112)

* fix broken link in index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update docs/content/concepts/faq/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* update gh to ado sync workflow to use service principals

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add Connections crosslinks to Existing app tutorial (#1103)

* add Connections crosslinks to Existing app tutorial

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add more crosslinks

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update config.toml

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>

* Update index.md (#1121)

Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup`

(added missing `-`)

Signed-off-by: Loek Duys <loekd@hotmail.com>

* add new logo types (#1122)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Add CNCF website guidelines (#1123)

* Add copyrights

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

---------

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Upmerge

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
willtsai added a commit that referenced this pull request Jun 20, 2024
* Update docs for v0.33.0

* update gh to ado sync workflow to use service principals (#1118)

* Update docs for v0.32.0

* Update environment logic (#1097)

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>

* Superbeeny/adding podspec secrets (#1100)

* Adding example on how to access secrets and add them to the container environment

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Adding code tabs where the commands differ between linux/windows

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* Updates requested from PR review

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

* nit: add a new line for spacing aesthetics

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Make env configurable (#1102)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* fix(bug): Update index.md (#1113)

* fix(bug): Update index.md

Fixed a bug in the cleanup script.

The command `rad app delete demo -y`
results in this output:
`Application 'demo' does not exist or has already been deleted.`

The command should be:
`rad app delete -y`
The output will be:
`Application first-app deleted`

Signed-off-by: Loek Duys <loekd@hotmail.com>

* Update docs/content/getting-started/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Fix broken link in faq (#1112)

* fix broken link in index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update index.md

Signed-off-by: Dan Moseley <danmose@microsoft.com>

* Update docs/content/concepts/faq/index.md

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* update gh to ado sync workflow to use service principals

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add Connections crosslinks to Existing app tutorial (#1103)

* add Connections crosslinks to Existing app tutorial

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* add more crosslinks

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Update config.toml

Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>

* Update index.md (#1121)

Fixed typo `-resource-group myResourceGroup` into `--resource-group myResourceGroup`

(added missing `-`)

Signed-off-by: Loek Duys <loekd@hotmail.com>

* add new logo types (#1122)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Add CNCF website guidelines (#1123)

* Add copyrights

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Add trademark

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

---------

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* Update docs for v0.34.0

* Update command to view deployed container in tutorial (#1128)

* Update command to view deployed container in tutorial

Signed-off-by: Filipe Revez <filipevrevez@outlook.com>

* Fixed another wrong rad app connections command

Signed-off-by: Filipe Revez <filipevrevez@outlook.com>

---------

Signed-off-by: Filipe Revez <filipevrevez@outlook.com>

* fix ado sync workflow (#1130)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Revert "Merge branch 'v0.33' into v0.34" (#1133)

This reverts commit bfba3f3, reversing
changes made to e36f280.

* fix dead links in contribution guide (#1135)

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* Rename app connections (#1129)

Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>

* revert changes

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <reshmarahim.abdul@microsoft.com>
Signed-off-by: Loek Duys <loekd@hotmail.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Dan Moseley <danmose@microsoft.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Filipe Revez <filipevrevez@outlook.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Co-authored-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Loek Duys <loekd@hotmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Co-authored-by: Filipe Revez <77700764+filipevrevez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants