Dapr tutorial Application ID updates#913
Merged
Merged
Conversation
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
AaronCrawfis
approved these changes
Oct 26, 2023
AaronCrawfis
suggested changes
Oct 26, 2023
| 1. Begin in a new directory for your application: | ||
|
|
||
| ```bash | ||
| mkdir rad-dapr |
There was a problem hiding this comment.
This conflicts with https://github.com/radius-project/samples/pull/654/files#r1372333903. We should have the directory match the app name
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
AaronCrawfis
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Corrections to the bicep definitions to use CLI-injected app id instead of custom-defined app id.
Auto-generated description
🤖 Generated by Copilot at ce7bf4f
Summary
📝🛠️🚀
Improved the
tutorial-daprdocument and bicep file to make them easier to use and understand. Parameterized the application ID in thedapr.bicepfile and clarified the prerequisites and cleanup steps in thetutorial-dapr/index.mdfile.Walkthrough
dapr.bicepfile to enable automatic injection and customization (link, link, link, link)tutorial-dapr/index.mdfile to include setting up a Kubernetes cluster and initializing a Radius environment (link)tutorial-dapr/index.mdfile to use the default application name and format the keyboard shortcut consistently (link)Issue reference
Related to: radius-project/samples#654
Fixes: radius-project/samples#654