dapr tutorial port fix#926
Merged
Merged
Conversation
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Contributor
Author
|
the additional env variable added is per https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/web-host?view=aspnetcore-3.1#server-urls-2 |
ytimocin
approved these changes
Nov 3, 2023
ytimocin
reviewed
Nov 3, 2023
| // An environment variable to tell the frontend container where to find the backend | ||
| CONNECTION_BACKEND_APPID: 'backend' | ||
| // An environment variable to override the default port that .NET Core listens on | ||
| ASPNETCORE_URLS: 'http://*:8080' |
Contributor
There was a problem hiding this comment.
Does it only serve through HTTP?
Contributor
Author
There was a problem hiding this comment.
@ytimocin -- not sure, but http is the relevant protocol for our tutorial, so I think this should be okay?
Contributor
There was a problem hiding this comment.
We only need HTTP for the tutorial. .NET does both (even in development scenarios).
rynowak
approved these changes
Nov 3, 2023
AaronCrawfis
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
add env var to override the default port
80that the .NETfrontendapp uses to8080instead, since port80is problematic for localhost testing.Auto-generated description
🤖 Generated by Copilot at faaadf2
Summary
🚀🛠️📝
Updated the bicep template for the .NET Core web app to use a different port than the Dapr sidecar. This change supports the tutorial-dapr scenario.
Walkthrough
Issue reference
Fixes: #916