Skip to content

feat: concise single-line output for all rad create commands#11770

Closed
Copilot wants to merge 7 commits intomainfrom
copilot/update-rad-create-output
Closed

feat: concise single-line output for all rad create commands#11770
Copilot wants to merge 7 commits intomainfrom
copilot/update-rad-create-output

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

Description

rad resource-type create leaked internal manifest-registration progress messages to the CLI output. manifest.EnsureResourceProviderExists and manifest.RegisterType call logIfEnabled, which fires whenever a non-nil logger is passed. The Runner was wiring its Logger field (backed by output.LogInfo) into both calls, producing noise like:

Creating resource type Radius.Data/testResources
Creating API Version Radius.Data/testResources@2025-08-01-preview
Resource type Radius.Data/testResources created successfully
resource-type/Radius.Data/testResources created   ← only this line is intended

create.go

  • Remove Logger field from Runner and its initialisation in NewRunner.
  • Pass nil to both manifest.EnsureResourceProviderExists and manifest.RegisterType, suppressing all intermediate log output.

create_test.go

  • Drop logBuffer/logger setup and the Logger field from all Runner literals (4 test cases).
  • Remove assertions that verified the now-suppressed log messages (require.Contains on "Creating resource type …").
  • Remove unused "bytes" import.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Copilot AI changed the title [WIP] Update rad create commands for single line output on success feat: concise single-line output for all rad create commands Apr 27, 2026
Copilot AI requested a review from zachcasper April 27, 2026 21:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.41%. Comparing base (210a9ec) to head (45b61ce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11770      +/-   ##
==========================================
+ Coverage   51.38%   51.41%   +0.03%     
==========================================
  Files         698      698              
  Lines       44037    44023      -14     
==========================================
+ Hits        22627    22636       +9     
+ Misses      19252    19239      -13     
+ Partials     2158     2148      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Unit Tests

    2 files  ±0    415 suites  ±0   6m 50s ⏱️ +13s
4 865 tests ±0  4 863 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 768 runs  ±0  5 766 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 45b61ce. ± Comparison against base commit 210a9ec.

♻️ This comment has been updated with latest results.

Copilot AI requested a review from zachcasper April 28, 2026 13:38
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests Bot commented Apr 28, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 45b61ce
Unique ID func11e7da1542
Image tag pr-func11e7da1542
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func11e7da1542
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func11e7da1542
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func11e7da1542
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func11e7da1542
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func11e7da1542
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@zachcasper
Copy link
Copy Markdown
Contributor

Closing, replaced by #11773

@zachcasper zachcasper closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All rad <resource> create commands should output a single line if successful

2 participants