fixes #7592 - adding typed to mockgen by superbeeny · Pull Request #7647 · radius-project/radius

superbeeny · 2024-05-30T18:32:36Z

Description

Fixes issue #7592 - adding types to generated mocks

Type of change

This pull request fixes a bug in Radius and has an approved issue Use typed mocks #7592 .

Fixes: #7592

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

…n dequeue test Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

codecov · 2024-05-30T19:08:56Z

Codecov Report

Attention: Patch coverage is 50.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (d1a55c9) to head (9db30fb).

Files	Patch %	Lines
pkg/cli/azure/client_mock.go	50.00%	30 Missing ⚠️
pkg/cli/aws/client_mock.go	50.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7647      +/-   ##
==========================================
- Coverage   61.02%   61.00%   -0.02%     
==========================================
  Files         518      518              
  Lines       26557    26627      +70     
==========================================
+ Hits        16207    16245      +38     
- Misses       8918     8955      +37     
+ Partials     1432     1427       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-05-30T19:19:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`be3732a`
Unique ID	func3b630be337
Image tag	pr-func3b630be337

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3b630be337
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3b630be337
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3b630be337
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3b630be337
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

kachawla

Thanks for doing this @superbeeny!

Co-authored-by: Karishma Chawla <kachawla@microsoft.com> Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

radius-functional-tests · 2024-06-03T12:59:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`8322fa3`
Unique ID	func591bd01fd5
Image tag	pr-func591bd01fd5

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func591bd01fd5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func591bd01fd5
controller test image location: ghcr.io/radius-project/dev/controller:pr-func591bd01fd5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func591bd01fd5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

ytimocin · 2024-06-03T12:59:28Z

Thanks for your contribution @superbeeny! You should run make generate in your local and then commit the generated changes.

radius-functional-tests · 2024-06-03T13:49:49Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`f8a82b7`
Unique ID	funcab84c4c766
Image tag	pr-funcab84c4c766

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcab84c4c766
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcab84c4c766
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcab84c4c766
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcab84c4c766
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

ytimocin · 2024-06-03T13:54:11Z

One last thing :) DCO is failing: https://github.com/radius-project/radius/pull/7647/checks?check_run_id=25736485013. You should sign your commit. I guess, if you do git commit -s --amend and push all the changes again, it should be signed. Thanks @superbeeny!

superbeeny · 2024-06-03T14:03:49Z

One last thing :) DCO is failing: https://github.com/radius-project/radius/pull/7647/checks?check_run_id=25736485013. You should sign your commit. I guess, if you do git commit -s --amend and push all the changes again, it should be signed. Thanks @superbeeny!

It's the tracking branch merge that I'm guessing is causing the issue the commit before it is signed :(

superbeeny · 2024-06-03T14:40:56Z

There are days I really hate git 👎

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

radius-functional-tests · 2024-06-03T15:31:47Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`0b7bc41`
Unique ID	funcd3988862ad
Image tag	pr-funcd3988862ad

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd3988862ad
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd3988862ad
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd3988862ad
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd3988862ad
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

ytimocin

Thanks for this change @superbeeny! 🚀

ytimocin · 2024-06-03T15:35:13Z

 	}, nil)

-	secondCall := mockCli.EXPECT().Dequeue(gomock.Any(), gomock.Any()).Return(nil, ErrInvalidMessage).After(firstCall)
+	secondCall := mockCli.EXPECT().Dequeue(gomock.Any(), gomock.Any()).Return(nil, ErrInvalidMessage).After(firstCall.Call)


This is one of the changes that come with the mock updates, I guess.

I think we are using this (second call should be after the first call test) only in this test.

radius-functional-tests · 2024-06-03T23:43:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`9db30fb`
Unique ID	func39dcd008ba
Image tag	pr-func39dcd008ba

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func39dcd008ba
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func39dcd008ba
controller test image location: ghcr.io/radius-project/dev/controller:pr-func39dcd008ba
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func39dcd008ba
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

lakshmimsft · 2024-06-04T15:47:50Z

Thanks @superbeeny. I'm merging this in.

# Description Fixes issue #7592 - adding types to generated mocks ## Type of change - This pull request fixes a bug in Radius and has an approved issue #7592 . Fixes: #7592 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com> Co-authored-by: Karishma Chawla <kachawla@microsoft.com>

) # Description Fixes issue radius-project#7592 - adding types to generated mocks ## Type of change - This pull request fixes a bug in Radius and has an approved issue radius-project#7592 . Fixes: radius-project#7592 --------- Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com> Co-authored-by: Karishma Chawla <kachawla@microsoft.com>

fixes radius-project#7592 - adding typed to mockgen

79239a0

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny requested review from a team as code owners May 30, 2024 18:32

fixes radius-project#7592 - fixing error in test, unwrapping struct i…

be3732a

…n dequeue test Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny temporarily deployed to functional-tests May 30, 2024 19:19 — with GitHub Actions Inactive

lakshmimsft previously approved these changes May 30, 2024

View reviewed changes

kachawla reviewed May 31, 2024

View reviewed changes

Comment thread pkg/cli/clients/management_mocks.go Outdated

Update pkg/cli/clients/management_mocks.go

6696aab

Co-authored-by: Karishma Chawla <kachawla@microsoft.com> Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny dismissed lakshmimsft’s stale review via 6696aab June 3, 2024 12:22

Merge branch 'main' into superbeeny/fixes7592

8322fa3

superbeeny temporarily deployed to functional-tests June 3, 2024 12:58 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests June 3, 2024 13:49 — with GitHub Actions Inactive

fixes radius-project#7592 - adding generated mocks

0b7bc41

Signed-off-by: Nick Beenham <1985327+superbeeny@users.noreply.github.com>

superbeeny force-pushed the superbeeny/fixes7592 branch from e7ff963 to 0b7bc41 Compare June 3, 2024 15:21

superbeeny temporarily deployed to functional-tests June 3, 2024 15:31 — with GitHub Actions Inactive

ytimocin approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'main' into superbeeny/fixes7592

9db30fb

kachawla approved these changes Jun 3, 2024

View reviewed changes

kachawla temporarily deployed to functional-tests June 3, 2024 23:43 — with GitHub Actions Inactive

lakshmimsft approved these changes Jun 4, 2024

View reviewed changes

lakshmimsft merged commit e3900e3 into radius-project:main Jun 4, 2024

superbeeny mentioned this pull request Jan 29, 2025

REQUEST: Approver for superbeeny radius-project/community#76

Closed

4 tasks

Conversation

superbeeny commented May 30, 2024

Description

Type of change

Uh oh!

codecov Bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radius-functional-tests Bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

kachawla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

radius-functional-tests Bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

ytimocin commented Jun 3, 2024

Uh oh!

radius-functional-tests Bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

ytimocin commented Jun 3, 2024

Uh oh!

superbeeny commented Jun 3, 2024

Uh oh!

superbeeny commented Jun 3, 2024

Uh oh!

radius-functional-tests Bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

ytimocin left a comment

Choose a reason for hiding this comment

Uh oh!

ytimocin Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

ytimocin Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests Bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

lakshmimsft commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 30, 2024 •

edited

Loading

radius-functional-tests Bot commented May 30, 2024 •

edited

Loading

radius-functional-tests Bot commented Jun 3, 2024 •

edited

Loading

radius-functional-tests Bot commented Jun 3, 2024 •

edited

Loading

radius-functional-tests Bot commented Jun 3, 2024 •

edited

Loading

radius-functional-tests Bot commented Jun 3, 2024 •

edited

Loading